xiaobaicai66695 opened a new pull request, #3696:
URL: https://github.com/apache/dubbo-go/pull/3696

   ### What changed
   - Replaced Vault `jsonutil.EncodeJSON` / `jsonutil.DecodeJSON` usages in 
etcdv3 service discovery with local helpers backed by `encoding/json`.
   - Preserved `DecodeJSON` number handling by using `json.Decoder.UseNumber()`.
   - Removed the direct `github.com/hashicorp/vault/sdk` requirement from the 
main module.
   - Cleaned stale Vault SDK checksum entries from dubbogo-cli 
scaffold/template go.sum data where applicable.
   
   ### Notes
   - This PR intentionally covers only item 1 from #3693: Vault `jsonutil` -> 
`encoding/json`.
   - `go mod tidy` still keeps `github.com/hashicorp/vault/sdk v0.1.13/go.mod` 
in the main `go.sum` through the transitive module path `github.com/knadh/koanf 
-> github.com/hashicorp/vault/api -> github.com/hashicorp/vault/sdk`. The main 
module itself does not need `github.com/hashicorp/vault/sdk` according to `go 
mod why -m`.
   
   ### Tests
   - `go test -count=1 ./registry/etcdv3`
   - `(cd tools/dubbogo-cli && go test -count=1 ./...)`
   
   Refs #3693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to