NeverENG commented on code in PR #3690:
URL: https://github.com/apache/dubbo-go/pull/3690#discussion_r3836066343
##########
.github/workflows/github-actions.yml:
##########
@@ -41,13 +41,46 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
+ # Set at job level (not just on one step) so every step below - Run unit
+ # tests and Race Test alike - explicitly points config_center/zookeeper's
+ # tests at the service container. That's also what makes
+ # failOrSkipZkUnavailable (config_center/zookeeper/impl_test.go) fail
+ # those tests instead of skipping them if the server it names isn't
+ # reachable: ZK_ADDR being set here is this job asserting "a ZooKeeper
+ # must be up", so an unreachable one is this job's own regression, not
+ # something to pass over quietly.
+ env:
Review Comment:
已按你的意见移除 unit-test job 的 ZK service / ZK_ADDR / Wait 步骤（ef17e725），ZooKeeper
场景继续由集成测试 docker 覆盖。
##########
go.mod:
##########
@@ -64,10 +65,10 @@ require (
go.yaml.in/yaml/v4 v4.0.0-rc.6
golang.org/x/net v0.56.0
golang.org/x/sync v0.21.0
- golang.org/x/tools v0.47.0
google.golang.org/grpc v1.64.1
google.golang.org/protobuf v1.34.2
gopkg.in/natefinch/lumberjack.v2 v2.2.1
+ gopkg.in/yaml.v3 v3.0.1
Review Comment:
已重新提交（d08a9d59）：tools/benchmark/client/main.go 使用 go.yaml.in/yaml/v4，go mod
tidy 后 gopkg.in/yaml.v3 保持 indirect，与 #3586 一致。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
