Alanxtl commented on code in PR #3681:
URL: https://github.com/apache/dubbo-go/pull/3681#discussion_r3809468130
##########
protocol/triple/options.go:
##########
@@ -188,6 +188,34 @@ func Http3Negotiation(negotiation bool) Option {
}
}
+// Http3KeepAlivePeriod sets how often the HTTP/3 transport sends QUIC
keep-alive packets.
+func Http3KeepAlivePeriod(period time.Duration) Option {
+ return func(opts *Options) {
+ opts.Triple.Http3.KeepAlivePeriod = period.String()
+ }
+}
Review Comment:
为啥这些option不是withXXX的style 比如这个是WithHttp3KeepAlivePeriod()
如果可以的话 上面的那两个Http3Negotiation Http3Enable也应该是这种style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
