AlexStocks commented on code in PR #3674:
URL: https://github.com/apache/dubbo-go/pull/3674#discussion_r3800824415
##########
global/http3_config.go:
##########
@@ -19,27 +19,30 @@ package global
// Http3Config represents the config of http3 protocol.
type Http3Config struct {
- // Enable defines whether to enable HTTP/3 support.
- // When set to true, both HTTP/2 and HTTP/3 servers will be started
simultaneously.
- // When set to false, only HTTP/2 server will be started.
+ // Enable defines whether HTTP/3 support is enabled for server.
Review Comment:
[P2] 这里把 `Enable` 限定成了服务端配置，但当前 Head 的 `protocol/triple/client.go:188` 也读取
`tripleConf.Http3.Enable`，为 `true` 时客户端会选择 HTTP/2+HTTP/3 dual
transport。因此该字段同时决定服务端是否启动 HTTP/3、客户端是否创建 HTTP/3
transport；请让注释覆盖两端并分别说明语义，避免客户端用户误以为这个开关对其无效。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
