RainYuY commented on code in PR #16416:
URL: https://github.com/apache/dubbo/pull/16416#discussion_r3765466771
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/grpc/GrpcHttp2ServerTransportListener.java:
##########
@@ -170,7 +170,7 @@ private class LazyFindMethodListener implements
HttpMessageListener {
private final StreamingDecoder streamingDecoder;
private LazyFindMethodListener() {
- streamingDecoder = new GrpcStreamingDecoder();
+ streamingDecoder = getStreamingDecoder();
streamingDecoder.setFragmentListener(new
DetermineMethodDescriptorListener());
streamingDecoder.request(Integer.MAX_VALUE);
Review Comment:
> @RainYuY I took a look and it's indeed possible. The `request(max)` part
in the diff above was from the previous temporary decoder logic, meaning giving
the decoder an extremely large message quota. This indeed had no impact on the
temporary decoder, but the change I made here actually set up the main decoder,
and the subsequent automatic backpressure mechanism works in an accumulative
way, so it will affect the backpressure mechanism. Currently, my understanding
is to remove the `request max`.Based on your review, I hope I've made myself
clear. I'll submit a commit to fix this backpressure issue when I get off work
tonight
I think so, but I don’t have time right now to check whether removing this
will have any impact. You can go ahead and do it. I’ll check it later, and if
there are no problems, I’ll approve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
