AlexStocks commented on code in PR #395:
URL: https://github.com/apache/dubbo-go-hessian2/pull/395#discussion_r3578176109


##########
.asf.yaml:
##########
@@ -1,5 +1,19 @@
 notifications:
-    commits:      [email protected]
-    issues:       [email protected]
-    pullrequests: [email protected]
-    jira_options: link label link label
+  commits: [email protected]
+  issues: [email protected]
+  pullrequests: [email protected]
+  jira_options: link label link label
+github:
+  rulesets:
+    - name: "Default Branch Protection"
+      type: branch
+      branches:
+        includes:
+          - "~DEFAULT_BRANCH"
+          - "release/*"

Review Comment:
   [P1] 现有发布分支没有被这些模式命中
   
   仓库实时分支是 `1.3` 到 `1.12`,它们当前全部 `protected=false`;ASF normalizer 生成的条件只有 
`~DEFAULT_BRANCH`、`refs/heads/release/*` 和 `refs/heads/rel/*`,因此合并后实际只覆盖 
`master`,这些版本维护分支仍可被删除或强推。这与 PR 声明保护默认分支和发布分支不一致。请按仓库真实命名补充数值版本分支模式(或显式 include 
列表),并在提交前用实时 branch list 对账覆盖范围。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to