mochengqian commented on code in PR #1477:
URL: https://github.com/apache/dubbo-admin/pull/1477#discussion_r3577338175
##########
pkg/config/app/admin.go:
##########
@@ -51,24 +52,28 @@ type AdminConfig struct {
Engine *engine.Config `json:"engine" yaml:"engine"`
// EventBus configuration
EventBus *eventbus.Config `json:"eventBus,omitempty"
yaml:"eventBus,omitempty"`
+ // RuleVersioning records lightweight audit history for
governor-managed traffic rules.
+ // Live rule state remains in ResourceManager/registry.
+ RuleVersioning *versioning.Config `json:"ruleVersioning,omitempty"
yaml:"ruleVersioning,omitempty"`
}
var _ = &AdminConfig{}
var DefaultAdminConfig = func() AdminConfig {
eventBusCfg := eventbus.Default()
return AdminConfig{
- Log: log.DefaultLogConfig(),
- Store: store.DefaultStoreConfig(),
- Engine: engine.DefaultResourceEngineConfig(),
- Observability: observability.DefaultObservabilityConfig(),
- Diagnostics: diagnostics.DefaultDiagnosticsConfig(),
- Console: console.DefaultConsoleConfig(),
- EventBus: &eventBusCfg,
+ Log: log.DefaultLogConfig(),
+ Store: store.DefaultStoreConfig(),
+ Engine: engine.DefaultResourceEngineConfig(),
+ Observability: observability.DefaultObservabilityConfig(),
+ Diagnostics: diagnostics.DefaultDiagnosticsConfig(),
+ Console: console.DefaultConsoleConfig(),
+ EventBus: &eventBusCfg,
+ RuleVersioning: versioning.Default(),
}
}
-func (c AdminConfig) Sanitize() {
+func (c *AdminConfig) Sanitize() {
Review Comment:
如果使用值接收者，赋值只发生在 AdminConfig 副本上，调用结束后默认值丢失,因此这里使用指针接收者。已按您的建议统一 AdminConfig
为指针接收者
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
