ume3445 opened a new pull request, #16378: URL: https://github.com/apache/dubbo/pull/16378
Fixes #16376 ## What is the purpose of the change? MeshRuleRouter.getDubboRouteDestination(DubboRoute, Invocation) used allMatch when evaluating the match list within a DubboRouteDetail, requiring every DubboMatchRequest alternative to match simultaneously. Per Dubbo's mesh routing semantics (modeled on Istio VirtualService), conditions within a single match entry should use AND, but multiple entries in the match list should use OR. This PR changes allMatch to anyMatch and adds a regression test covering the multi-alternative case, which the existing test fixtures never exercised (they only ever had a single match entry per detail, so AND and OR behaved identically). ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues/16376) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
