Copilot commented on code in PR #3482:
URL: https://github.com/apache/dubbo-go/pull/3482#discussion_r3563393819
##########
registry/polaris/registry.go:
##########
@@ -169,6 +165,22 @@ func (pr *polarisRegistry) Subscribe(url *common.URL,
notifyListener registry.No
}
}
+// createPolarisListener creates or reuses the service watcher, transfers its
pending baseline,
+// and only then invokes newListener so the watcher cannot start before
snapshot injection.
+func (pr *polarisRegistry) createPolarisListener(
Review Comment:
The doc comment claims the watcher "cannot start before snapshot injection",
but that’s only guaranteed for a newly-created watcher; an existing watcher may
already be running. Tweaking the wording would avoid implying a stronger
guarantee than the code can provide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
