AsperforMias commented on code in PR #3479:
URL: https://github.com/apache/dubbo-go/pull/3479#discussion_r3542431378
##########
registry/nacos/registry.go:
##########
@@ -62,8 +62,9 @@ func init() {
type nacosRegistry struct {
*common.URL
- namingClient *nacosClient.NacosNamingClient
- registryUrls []*common.URL
+ namingClient *nacosClient.NacosNamingClient
Review Comment:
> 这个是因为`NacosNamingClient` 是 gost 创建出来的 client，内部有锁和共享状态，registry 和 listener
需要共享同一个实例，改成 value 会复制 client 的状态（
老代码也是pointer 也是因为这个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
