Aias00 commented on code in PR #3440:
URL: https://github.com/apache/dubbo-go/pull/3440#discussion_r3542012752
##########
remoting/exchange.go:
##########
@@ -172,8 +172,8 @@ func AddPendingResponse(pr *PendingResponse) {
pendingResponses.Store(SequenceType(pr.seq), pr)
}
-// get and remove response
-func removePendingResponse(seq SequenceType) *PendingResponse {
+// RemovePendingResponse gets and removes the pending response for the given
sequence ID.
+func RemovePendingResponse(seq SequenceType) *PendingResponse {
Review Comment:
这个得导出,是因为有一处内存泄漏是在 remoting/getty/listener.go 的心跳超时里处理的，它属于 getty 包,必须跨包调用
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
