Alanxtl commented on code in PR #3471:
URL: https://github.com/apache/dubbo-go/pull/3471#discussion_r3534147026
##########
metrics/prometheus/registry_test.go:
##########
@@ -154,12 +152,12 @@ func TestPromMetricRegistryExport(t *testing.T) {
err :=
http.ListenAndServe(url.GetParam(constant.PrometheusPushgatewayBaseUrlKey, ""),
http.HandlerFunc(func(w http.ResponseWriter, r
*http.Request) {
bodyBytes, err := io.ReadAll(r.Body)
- assert.NoError(t, err)
+ require.NoError(t, err)
Review Comment:
done
##########
protocol/triple/dual_transport_test.go:
##########
@@ -134,17 +134,15 @@ func
TestDualTransport_ConcurrentH2DiscoveryStartsSingleProbe(t *testing.T) {
var wg sync.WaitGroup
wg.Add(numRequests)
- for i := 0; i < numRequests; i++ {
+ for range numRequests {
req, err := http.NewRequest(http.MethodPost,
"https://example.com/service";, nil)
require.NoError(t, err)
go func(req *http.Request) {
defer wg.Done()
resp, err := dt.RoundTrip(req)
- if !assert.NoError(t, err) {
- return
- }
+ require.NoError(t, err)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
