HarshMehta112 opened a new pull request, #3474:
URL: https://github.com/apache/dubbo-go/pull/3474
Fixes #3453
### Description
#### 2. Getty server no longer panics on config errors
`remoting/getty/getty_server.go`
Replaced `panic(err)` in config marshal/unmarshal, `CheckValidity()`, and
`newSession()`
with structured error logging / error returns. Added `safeYAMLMarshal` to
recover the
panic `yaml.v3` raises on unmarshalable types (channels, funcs) and
surface it as an error.
Malformed protocol config no longer escalates to process-level failure.
### Tests
- `TestInitServerDoesNotPanicOnUnmarshalableParams` — channel in Params no
longer panics
### Checklist
- [x] I confirm the target branch is `develop`
- [x] Code has passed local testing
- [x] I have added tests that prove my fix is effective or that my feature
works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
