Aetherance commented on code in PR #3305:
URL: https://github.com/apache/dubbo-go/pull/3305#discussion_r3293014958
##########
cluster/router/tag/router.go:
##########
@@ -52,6 +57,16 @@ func (p *PriorityRouter) Route(invokers []base.Invoker, url
*common.URL, invocat
logger.Warnf("[tag router] invokers from previous router is
empty")
return invokers
}
+
Review Comment:
目前使用 fullInvokers 是安全的，因为当 TagRouter 之前存在前置路由器进行路由时，RouterCacheDisable 会被置为
true，此时将不会执行 routeWithPool，因此不会触发基于缓存的路由逻辑。
并且，目前也添加了注释进行说明
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
