LI123456mo commented on code in PR #16255:
URL: https://github.com/apache/dubbo/pull/16255#discussion_r3193144763
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/ssl/SslServerTlsHandler.java:
##########
@@ -65,6 +65,8 @@ public void exceptionCaught(ChannelHandlerContext ctx,
Throwable cause) throws E
"",
"TLS negotiation failed when trying to accept new connection.",
cause);
+ ctx.close();
Review Comment:
> should close context after calling fireExceptionCaught
Thank you for the feedback, @zrlw. That makes sense—firing the exception
first ensures the error is fully propagated through the pipeline before the
channel is terminated. I will update the PR to swap the order:
ctx.fireExceptionCaught(cause) followed by ctx.close().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
