AlexStocks commented on code in PR #135:
URL:
https://github.com/apache/dubbo-go-pixiu-samples/pull/135#discussion_r3164735355
##########
dubbogo/simple/body/server/app/server.go:
##########
@@ -39,7 +39,7 @@ var survivalTimeout = int(3e9)
// export CONF_PROVIDER_FILE_PATH="xxx"
// export APP_LOG_CONF_FILE="xxx"
func main() {
- config.Load()
+ dubbo.Load()
Review Comment:
[P1] 这里同样把 `config.Load()` 换成了有返回值的 `dubbo.Load()`，但没有检查 error；本轮
`golangci-lint` 已经在这行报 `errcheck`。配置加载失败时继续执行会让样例进入不完整启动状态，建议显式处理错误并终止启动。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
