nanjiek commented on code in PR #3311:
URL: https://github.com/apache/dubbo-go/pull/3311#discussion_r3158256775


##########
cluster/cluster/base/cluster_invoker.go:
##########
@@ -127,7 +127,7 @@ func (invoker *BaseClusterInvoker) doSelectInvoker(lb 
loadbalance.LoadBalance, i
                        return invokers[0]
                }
                base.SetInvokerUnhealthyStatus(invokers[0])
-               logger.Errorf("the invokers of %s is nil. ", 
invokers[0].GetURL().ServiceKey())
+               logger.Errorf("[Cluster] invoker unavailable, serviceKey=%s", 
invokers[0].GetURL().ServiceKey())

Review Comment:
   unavailable有很多种,不能定位到nil,最好后面加个解释
   ```suggestion
                logger.Errorf("[Cluster] invoker unavailable, serviceKey=%s, 
reason=nil", invokers[0].GetURL().ServiceKey())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to