uuuyuqi commented on code in PR #16231:
URL: https://github.com/apache/dubbo/pull/16231#discussion_r3136313397
##########
dubbo-common/src/test/java/org/apache/dubbo/common/extension/ExtensionLoaderTest.java:
##########
@@ -192,6 +200,23 @@ void test_getExtension_WithWrapper() {
assertEquals(echoCount2 + 1, Ext6Wrapper2.echoCount.get());
}
+ @Test
+ void test_getExtension_logsDebugWhenExtensionCreated() {
+ try (ExtensionLoaderTestContext<WrappedExt> testContext =
createExtensionLoaderTestContext(WrappedExt.class);
+ LogCollector logCollector =
LogCollector.attach(ExtensionLoader.class)) {
+ WrappedExt impl1 =
testContext.extensionLoader.getExtension("impl1");
+
+ assertNotNull(impl1);
+ assertTrue(logCollector.contains("Loaded extension instance,
type=" + WrappedExt.class.getName()));
+ assertTrue(logCollector.contains("name=impl1"));
+ assertTrue(logCollector.contains("instanceClass=" +
Ext6Wrapper1.class.getName())
+ || logCollector.contains("instanceClass=" +
Ext6Wrapper2.class.getName()));
+ assertTrue(logCollector.contains("wrapperClasses=["));
+ assertTrue(logCollector.contains(Ext6Wrapper1.class.getName()));
+ assertTrue(logCollector.contains(Ext6Wrapper2.class.getName()));
Review Comment:
no need to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
