WyRainBow commented on code in PR #1455:
URL: https://github.com/apache/dubbo-admin/pull/1455#discussion_r3107099126
##########
pkg/config/app/admin.go:
##########
@@ -115,7 +120,7 @@ func (c AdminConfig) PostProcess() error {
)
}
-func (c AdminConfig) Validate() error {
+func (c *AdminConfig) Validate() error {
Review Comment:
这条：Validate() 保持指针接收者，FindDiscovery()/Meshes() 保持值接收者（否则会在
ctx.Config().FindDiscovery(...) 场景触发编译错误：cannot call pointer method on
app.AdminConfig）这里就用会修改配置的方法用指针接收者、只读查询方法用值接收者的方式处理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
