AlexStocks commented on code in PR #3299:
URL: https://github.com/apache/dubbo-go/pull/3299#discussion_r3106174147
##########
global/http3_config.go:
##########
@@ -34,14 +34,28 @@ type Http3Config struct {
// ref:
https://quic-go.net/docs/http3/server/#advertising-http3-via-alt-svc
Negotiation bool `yaml:"negotiation" json:"negotiation,omitempty"`
- // TODO: add more params about http3
+ // KeepAlivePeriod defines how often to send keep-alive packets.
+ KeepAlivePeriod string `yaml:"keep-alive-period"
json:"keepAlivePeriod,omitempty"`
+
+ // MaxIdleTimeout defines the maximum idle timeout for QUIC connections.
+ MaxIdleTimeout string `yaml:"max-idle-timeout"
json:"maxIdleTimeout,omitempty"`
+
+ // MaxIncomingStreams defines the maximum number of concurrent
bidirectional streams.
+ MaxIncomingStreams int64 `yaml:"max-incoming-streams"
json:"maxIncomingStreams,omitempty"`
+
+ // MaxIncomingUniStreams defines the maximum number of concurrent
unidirectional streams.
+ MaxIncomingUniStreams int64 `yaml:"max-incoming-uni-streams"
json:"maxIncomingUniStreams,omitempty"`
Review Comment:
[P1] 这里是兼容性问题，不只是风格。`global` 配置结构现有约定是 YAML 和 JSON 一致使用 kebab-case，例如
`global/triple_config.go` 里的 `keep-alive-interval`、`global/protocol_config.go`
里的 `max-server-send-msg-size`。这 4 个新字段改成 camelCase 后，走 JSON
配置入口的用户会出现新字段名与现有配置体系不一致，已有文档/样例也很容易写错。建议把 JSON tag 改成和 YAML 一致的 kebab-case。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
