uuuyuqi opened a new pull request, #16202: URL: https://github.com/apache/dubbo/pull/16202
## What is the purpose of the change? Fixes #16201 `SslServerTlsHandler.exceptionCaught()` only logged errors without closing the channel or propagating the exception. This caused channels to remain TCP-active but application-dead (half-open) when non-IOException/non-OutOfMemoryError exceptions (e.g., `NoClassDefFoundError`) occurred during Netty's read loop. **Impact**: Consumer-side `DubboInvoker.isAvailable()` always returned `true` for these broken connections (it only checks TCP-level `channel.isActive()`), so the `addInvalidateInvoker` mechanism never triggered. The broken Provider was never removed from `validInvokers`, causing continuous RPC timeouts. **Changes**: - **`SslServerTlsHandler.exceptionCaught()`**: Added `ctx.close()` after logging, consistent with the `userEventTriggered()` method in the same class which already closes the channel on TLS handshake failure. - **`SslClientTlsHandler.userEventTriggered()`**: Changed from `ctx.fireExceptionCaught()` to `ctx.close()` on handshake failure, consistent with server-side behavior and ensuring the channel is properly closed so the Consumer can detect the failure. ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. (#16201) - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
