AlexStocks commented on code in PR #3253:
URL: https://github.com/apache/dubbo-go/pull/3253#discussion_r2939919559
##########
filter/filter_impl/import.go:
##########
@@ -28,7 +28,6 @@ import (
_ "dubbo.apache.org/dubbo-go/v3/filter/exec_limit"
_ "dubbo.apache.org/dubbo-go/v3/filter/generic"
_ "dubbo.apache.org/dubbo-go/v3/filter/graceful_shutdown"
- _ "dubbo.apache.org/dubbo-go/v3/filter/hystrix"
Review Comment:
hystrix 的 import 删了，但 `filter/README.md` 第 32 行还列着
hystrix，得一起清掉，不然看文档的人会以为主仓库还有这个 filter。
##########
server/options.go:
##########
@@ -389,8 +389,6 @@ func WithServerProtocol(opts ...protocol.ServerOption)
ServerOption {
}
}
-// todo(DMwangnima): this configuration would be used by filter/hystrix
-// think about a more ideal way to configure
func WithServerFilterConf(conf any) ServerOption {
Review Comment:
这两行 todo 注释删了之后，`WithServerFilterConf` 就完全没有文档了。这个函数原本就是给 hystrix 用的，现在
hystrix 搬走了，要么补个注释说明这个 API 留着干嘛、`conf any` 该传什么类型，要么确认没别的 filter
在用就直接一起删掉。Alanxtl 也问了同样的问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
