xxs588 commented on code in PR #3256:
URL: https://github.com/apache/dubbo-go/pull/3256#discussion_r2939091212
##########
cluster/router/chain/chain.go:
##########
@@ -109,12 +108,6 @@ func (c *RouterChain) copyRouters()
[]router.PriorityRouter {
// NewRouterChain init router chain
// Loop routerFactories and call NewRouter method
func NewRouterChain(url *common.URL) (*RouterChain, error) {
- if url.SubURL != nil {
- if appName := url.SubURL.GetParam(constant.ApplicationKey, "");
appName != "" {
- url.CompareAndSwapParam(constant.ApplicationKey, "",
appName)
- }
- }
Review Comment:
抱歉，这个修改在本次pr中破坏了提交的原子性，当时是因为 那个评论指出 问题根因是 polaris router 读取 application 的位置
，是router层的问题
然后就想直接收敛在router.go中修复就通过直接在router里面判断appName的位置，就不用再在chain.go里面再多判断一次Param了，但是这个删除属于额外行为变更，不该和本次
fix 混在一起。如果有必要修改的话，我可以再开一个commit或者独立的pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
