Snow-kal commented on code in PR #3231:
URL: https://github.com/apache/dubbo-go/pull/3231#discussion_r2936182231
##########
protocol/dubbo3/dubbo3_invoker.go:
##########
@@ -72,20 +71,21 @@ func NewDubboInvoker(url *common.URL) (*DubboInvoker,
error) {
rt string
consumerService any
)
- // TODO: Temporary compatibility with old APIs, can be removed later
- rt = config.GetConsumerConfig().RequestTimeout
- if consumerConfRaw, ok := url.GetAttribute(constant.ConsumerConfigKey);
ok {
- if consumerConf, ok :=
consumerConfRaw.(*global.ConsumerConfig); ok {
- rt = consumerConf.RequestTimeout
+ rt = url.GetParam(constant.TimeoutKey, "")
Review Comment:
感谢建议 已经把多余的 url.GetParam(constant.TimeoutKey, "")删除
按照建议简化
<img width="1888" height="500" alt="image"
src="https://github.com/user-attachments/assets/b38e69bf-b40f-4a6f-bb9b-25b5f4fb29aa";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
