Copilot commented on code in PR #3244:
URL: https://github.com/apache/dubbo-go/pull/3244#discussion_r2934572056
##########
go.mod:
##########
@@ -1,6 +1,6 @@
module dubbo.apache.org/dubbo-go/v3
-go 1.24.0
+go 1.25.0
Review Comment:
`go.mod` is now declaring `go 1.25.0`, but the repo’s GitHub Actions
workflow currently sets up Go 1.23 (see `.github/workflows/github-actions.yml`
matrix). This will either fail with “module requires go >= …” or silently force
toolchain download depending on env, which is brittle. Either keep the `go`
directive compatible with the workflow, or update CI to run Go 1.25 explicitly
(and/or add a `toolchain go1.25.0` directive if that’s the intended mechanism).
##########
Makefile:
##########
@@ -37,6 +37,7 @@ help:
# Run unit tests
test: clean
+ go env -w GOTOOLCHAIN=go1.25.0+auto
go test ./... -coverprofile=coverage.txt -covermode=atomic
cd $(CLI_DIR) && go test ./...
Review Comment:
`go env -w GOTOOLCHAIN=...` writes to the user’s persistent Go env config,
so running `make test` has side effects outside the repo and can surprise
developers/CI runners. Prefer setting `GOTOOLCHAIN=go1.25.0+auto` only for the
`go test` invocations (e.g., as an environment variable on the same line), or
manage the toolchain via `go.mod`’s `toolchain` directive instead of mutating
global state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
