Alanxtl commented on code in PR #3238: URL: https://github.com/apache/dubbo-go/pull/3238#discussion_r2917570818
########## server/server.go: ########## Review Comment: 这里的 `exportServices` 会访问 `svcOptsMap` `svcOptsMap` 的访问是需要锁来保护的，而 `exportServices` 方法并没有加锁 改造一下 `exportServices` 吧 另外检查一下 `exportInternalServices` 和 `RegisterServiceInstance` 是否线程安全 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
