AlexStocks commented on code in PR #1325:
URL: https://github.com/apache/dubbo-admin/pull/1325#discussion_r2365951428
##########
pkg/console/model/condition_rule.go:
##########
@@ -23,16 +23,21 @@ import (
meshproto "github.com/apache/dubbo-admin/api/mesh/v1alpha1"
"github.com/apache/dubbo-admin/pkg/core/consts"
+ coremodel "github.com/apache/dubbo-admin/pkg/core/resource/model"
)
type SearchConditionRuleReq struct {
Keywords string `json:"keywords"`
- PageReq
+ coremodel.PageReq
Review Comment:
move up
##########
pkg/console/model/configurator_rule.go:
##########
@@ -21,16 +21,18 @@ import (
"net/http"
meshproto "github.com/apache/dubbo-admin/api/mesh/v1alpha1"
+ coremodel "github.com/apache/dubbo-admin/pkg/core/resource/model"
)
type SearchConfiguratorReq struct {
Keywords string `json:"keywords"`
- PageReq
+ Mesh string `json:"mesh"`
+ coremodel.PageReq
Review Comment:
move up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
