Copilot commented on code in PR #926: URL: https://github.com/apache/dubbo-go-samples/pull/926#discussion_r2362959529
########## otel/tracing/otlp_http_exporter/proto/greet.proto: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = "proto3"; + +package greet; + +option go_package = "github.com/apache/dubbo-go-samples/otel/tracing/stdout/proto;greet"; Review Comment: The go_package option references the wrong directory path. It should be 'github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto;greet' instead of 'stdout/proto'. ```suggestion option go_package = "github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto;greet"; ``` ########## otel/tracing/otlp_http_exporter/tests/integration/otel_test.go: ########## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package integration + +import ( + "context" + "fmt" + "os" + "testing" + "time" +) + +import ( + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/otel/trace" + + "github.com/dubbogo/gost/log/logger" +) + +import ( + greetpb "github.com/apache/dubbo-go-samples/rpc/multi-protocols/proto" Review Comment: The import path references 'rpc/multi-protocols/proto' but should reference the local proto package at 'github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto' to match the actual location of the greet service definitions. ```suggestion greetpb "github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto" ``` ########## otel/tracing/otlp_http_exporter/go-server/cmd/main.go: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "compress/gzip" + "context" + "errors" + "io" + "net/http" + "strings" + "time" +) + +import ( + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/common" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/otel/trace" + "dubbo.apache.org/dubbo-go/v3/protocol" + "dubbo.apache.org/dubbo-go/v3/server" + + "github.com/dubbogo/gost/log/logger" + + "github.com/golang/protobuf/proto" + + collecttracepb "go.opentelemetry.io/proto/otlp/collector/trace/v1" +) + +import ( + greet "github.com/apache/dubbo-go-samples/otel/tracing/stdout/proto" Review Comment: The import path references 'stdout/proto' but should reference the local proto package at 'github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto' to match the actual location of the greet service definitions. ```suggestion greet "github.com/apache/dubbo-go-samples/otel/tracing/otlp_http_exporter/proto" ``` ########## otel/tracing/otlp_http_exporter/go-server/cmd/main.go: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "compress/gzip" + "context" + "errors" + "io" + "net/http" + "strings" + "time" +) + +import ( + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/common" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/otel/trace" + "dubbo.apache.org/dubbo-go/v3/protocol" + "dubbo.apache.org/dubbo-go/v3/server" + + "github.com/dubbogo/gost/log/logger" + + "github.com/golang/protobuf/proto" + + collecttracepb "go.opentelemetry.io/proto/otlp/collector/trace/v1" +) + +import ( + greet "github.com/apache/dubbo-go-samples/otel/tracing/stdout/proto" +) + +type GreetMultiRPCServer struct { +} + +func (srv *GreetMultiRPCServer) Greet(ctx context.Context, req *greet.GreetRequest) (*greet.GreetResponse, error) { + resp := &greet.GreetResponse{Greeting: req.Name} + return resp, nil +} + +type GreetProvider struct { +} + +func (*GreetProvider) SayHello(req string, req1 string, req2 string) (string, error) { + return req + " " + req1 + " " + req2, nil +} + +var ( + // triple + dubbo + jsonrpc + serverReceivesChan = make(chan bool, 3) + clientReceivesChan = make(chan bool, 3) + errChan = make(chan error, 6) +) + +func mockOtlpReceiver() { + http.HandleFunc("/v1/traces", func(w http.ResponseWriter, r *http.Request) { + defer r.Body.Close() + var reader io.Reader = r.Body + if strings.EqualFold(r.Header.Get("Content-Encoding"), "gzip") { + gr, err := gzip.NewReader(r.Body) + if err != nil { + errChan <- err + return + } + defer gr.Close() + reader = gr + } + raw, err := io.ReadAll(reader) + if err != nil { + errChan <- err + return + } + + var req collecttracepb.ExportTraceServiceRequest + if err = proto.Unmarshal(raw, &req); err != nil { + errChan <- err + return + } + + reqStr := req.String() + if strings.Contains(reqStr, "dubbo_otel_server") { + serverReceivesChan <- true + } else if strings.Contains(reqStr, "dubbo_otel_client") { + clientReceivesChan <- true + } else { + errChan <- errors.New("unknown trace" + reqStr) Review Comment: Missing space between 'trace' and the concatenated string. Should be 'unknown trace: ' + reqStr for better error message formatting. ```suggestion errChan <- errors.New("unknown trace: " + reqStr) ``` ########## otel/tracing/otlp_http_exporter/proto/greet.pb.go: ########## @@ -0,0 +1,193 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Code generated by protoc-gen-go. DO NOT EDIT. +// versions: +// protoc-gen-go v1.36.6 +// protoc v6.31.1 +// source: greet.proto + +package greet + +import ( + reflect "reflect" + sync "sync" + unsafe "unsafe" +) + +import ( + protoreflect "google.golang.org/protobuf/reflect/protoreflect" + + protoimpl "google.golang.org/protobuf/runtime/protoimpl" +) + +const ( + // Verify that this generated code is sufficiently up-to-date. + _ = protoimpl.EnforceVersion(20 - protoimpl.MinVersion) + // Verify that runtime/protoimpl is sufficiently up-to-date. + _ = protoimpl.EnforceVersion(protoimpl.MaxVersion - 20) +) + +type GreetRequest struct { + state protoimpl.MessageState `protogen:"open.v1"` + Name string `protobuf:"bytes,1,opt,name=name,proto3" json:"name,omitempty"` + unknownFields protoimpl.UnknownFields + sizeCache protoimpl.SizeCache +} + +func (x *GreetRequest) Reset() { + *x = GreetRequest{} + mi := &file_greet_proto_msgTypes[0] + ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) + ms.StoreMessageInfo(mi) +} + +func (x *GreetRequest) String() string { + return protoimpl.X.MessageStringOf(x) +} + +func (*GreetRequest) ProtoMessage() {} + +func (x *GreetRequest) ProtoReflect() protoreflect.Message { + mi := &file_greet_proto_msgTypes[0] + if x != nil { + ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) + if ms.LoadMessageInfo() == nil { + ms.StoreMessageInfo(mi) + } + return ms + } + return mi.MessageOf(x) +} + +// Deprecated: Use GreetRequest.ProtoReflect.Descriptor instead. +func (*GreetRequest) Descriptor() ([]byte, []int) { + return file_greet_proto_rawDescGZIP(), []int{0} +} + +func (x *GreetRequest) GetName() string { + if x != nil { + return x.Name + } + return "" +} + +type GreetResponse struct { + state protoimpl.MessageState `protogen:"open.v1"` + Greeting string `protobuf:"bytes,1,opt,name=greeting,proto3" json:"greeting,omitempty"` + unknownFields protoimpl.UnknownFields + sizeCache protoimpl.SizeCache +} + +func (x *GreetResponse) Reset() { + *x = GreetResponse{} + mi := &file_greet_proto_msgTypes[1] + ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) + ms.StoreMessageInfo(mi) +} + +func (x *GreetResponse) String() string { + return protoimpl.X.MessageStringOf(x) +} + +func (*GreetResponse) ProtoMessage() {} + +func (x *GreetResponse) ProtoReflect() protoreflect.Message { + mi := &file_greet_proto_msgTypes[1] + if x != nil { + ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) + if ms.LoadMessageInfo() == nil { + ms.StoreMessageInfo(mi) + } + return ms + } + return mi.MessageOf(x) +} + +// Deprecated: Use GreetResponse.ProtoReflect.Descriptor instead. +func (*GreetResponse) Descriptor() ([]byte, []int) { + return file_greet_proto_rawDescGZIP(), []int{1} +} + +func (x *GreetResponse) GetGreeting() string { + if x != nil { + return x.Greeting + } + return "" +} + +var File_greet_proto protoreflect.FileDescriptor + +const file_greet_proto_rawDesc = "" + + "\n" + + "\vgreet.proto\x12\x05greet\"\"\n" + + "\fGreetRequest\x12\x12\n" + + "\x04name\x18\x01 \x01(\tR\x04name\"+\n" + + "\rGreetResponse\x12\x1a\n" + + "\bgreeting\x18\x01 \x01(\tR\bgreeting2D\n" + + "\fGreetService\x124\n" + Review Comment: This generated code contains an incorrect go_package path reference from the proto file. The proto file should be regenerated after fixing the go_package option in greet.proto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
