RainYuY commented on code in PR #15695:
URL: https://github.com/apache/dubbo/pull/15695#discussion_r2355816276
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java:
##########
@@ -321,10 +322,13 @@ public void run(Timeout timeout) {
if (future == null || future.isDone()) {
return;
}
-
ExecutorService executor = future.getExecutor();
if (executor != null && !executor.isShutdown()) {
- executor.execute(() -> notifyTimeout(future));
+ try {
+ executor.execute(() -> notifyTimeout(future));
+ } catch (RejectedExecutionException e) {
+ notifyTimeout(future);
Review Comment:
I think it should throw an exception. Also, I think we need another PR to
change it so that it does not call notifyTimeout, because it’s not actually a
timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
