Copilot commented on code in PR #3016:
URL: https://github.com/apache/dubbo-go/pull/3016#discussion_r2328570934
##########
filter/auth/default_authenticator_test.go:
##########
@@ -119,9 +115,11 @@ func Test_getAccessKeyPairFailed(t *testing.T) {
testUrl = common.NewURLWithOptions(
common.WithParams(url.Values{}),
common.WithParamsValue(constant.SecretAccessKeyKey, "skey"),
- common.WithParamsValue(constant.AccessKeyIDKey, "akey"),
common.WithParamsValue(constant.AccessKeyStorageKey, "dubbo"))
+ common.WithParamsValue(constant.AccessKeyIDKey, "akey"),
+ common.WithParamsValue(constant.AccessKeyStorageKey, "dubbo"))
Review Comment:
[nitpick] Line 119 should be indented to align with the parameter on line
118 for better readability and consistency with Go formatting standards.
##########
common/extension/auth.go:
##########
@@ -17,6 +17,10 @@
package extension
+import (
+ "errors"
+)
+
import (
Review Comment:
[nitpick] Having separate import blocks for standard library and third-party
packages is unnecessary. Combine these into a single import block following Go
conventions.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
