manzhizhen commented on code in PR #3010:
URL: https://github.com/apache/dubbo-go/pull/3010#discussion_r2328430579
##########
protocol/base/rpc_status.go:
##########
@@ -159,21 +159,42 @@ func endCount0(rpcStatus *RPCStatus, elapsed int64,
succeeded bool) {
atomic.AddInt32(&rpcStatus.total, 1)
atomic.AddInt64(&rpcStatus.totalElapsed, elapsed)
- if rpcStatus.maxElapsed < elapsed {
- atomic.StoreInt64(&rpcStatus.maxElapsed, elapsed)
+ for {
Review Comment:
> 这三段代码类似,何不封装成一个 func?
有道理,我重新搞搞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]