Copilot commented on code in PR #2997:
URL: https://github.com/apache/dubbo-go/pull/2997#discussion_r2312402286
##########
filter/hystrix/filter_test.go:
##########
@@ -169,12 +169,12 @@ func TestHystrixFilterInvokeFail(t *testing.T) {
fmt.Sprintf("dubbo://%s:%d/com.ikurento.user.UserProvider",
constant.LocalHostValue, constant.DefaultPort))
assert.NoError(t, err)
testInvoker := testMockFailInvoker{*base.NewBaseInvoker(testUrl)}
- result := hf.Invoke(context.Background(), &testInvoker,
&invocation.RPCInvocation{})
- assert.NotNil(t, result)
- assert.Error(t, result.Error())
+ invokeResult := hf.Invoke(context.Background(), &testInvoker,
&invocation.RPCInvocation{})
+ assert.NotNil(t, invokeResult)
+ assert.Error(t, invokeResult.Error())
}
-func TestHystricFilterInvokeCircuitBreak(t *testing.T) {
+func TestHystrixFilterInvokeCircuitBreak(t *testing.T) {
Review Comment:
The function names contain a spelling error.
'TestHystricFilterInvokeCircuitBreak' should be
'TestHystrixFilterInvokeCircuitBreak' and
'TestHystricFilterInvokeCircuitBreakOmitException' should be
'TestHystrixFilterInvokeCircuitBreakOmitException' to match the correct
spelling of 'Hystrix'.
##########
filter/hystrix/filter_test.go:
##########
@@ -200,7 +200,7 @@ func TestHystricFilterInvokeCircuitBreak(t *testing.T) {
//assert.True(t, lastRest)
}
-func TestHystricFilterInvokeCircuitBreakOmitException(t *testing.T) {
+func TestHystrixFilterInvokeCircuitBreakOmitException(t *testing.T) {
Review Comment:
The function names contain a spelling error.
'TestHystricFilterInvokeCircuitBreak' should be
'TestHystrixFilterInvokeCircuitBreak' and
'TestHystricFilterInvokeCircuitBreakOmitException' should be
'TestHystrixFilterInvokeCircuitBreakOmitException' to match the correct
spelling of 'Hystrix'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
