Copilot commented on code in PR #92: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/92#discussion_r2312395255
########## llm/bestpractise/go-client/register_deepseek_service.go: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "encoding/json" + "fmt" + "os" + "os/signal" + "syscall" + "time" +) + +import ( + "github.com/dubbogo/gost/log/logger" + + "github.com/joho/godotenv" + + "github.com/nacos-group/nacos-sdk-go/clients" + "github.com/nacos-group/nacos-sdk-go/clients/naming_client" + "github.com/nacos-group/nacos-sdk-go/common/constant" + "github.com/nacos-group/nacos-sdk-go/vo" +) + +// Nacos server configuration +const ( + NacosServerIP = "127.0.0.1" + NacosServerPort = 8848 + NacosNamespace = "test_llm_registry_namespace" + NacosGroup = "test_llm_registry_group" + + ServiceName = "deepseek-service" +) + +// Create and return a Nacos client +func createNacosClient() (naming_client.INamingClient, error) { + serverConfigs := []constant.ServerConfig{ + *constant.NewServerConfig(NacosServerIP, NacosServerPort), + } + clientConfig := *constant.NewClientConfig( + constant.WithNamespaceId(NacosNamespace), + constant.WithTimeoutMs(5000), + constant.WithNotLoadCacheAtStart(true), + constant.WithLogDir("/tmp/nacos/log"), + constant.WithCacheDir("/tmp/nacos/cache"), + constant.WithLogLevel("info"), + ) + return clients.NewNamingClient( + vo.NacosClientParam{ + ClientConfig: &clientConfig, + ServerConfigs: serverConfigs, + }, + ) +} + +func main() { + err := godotenv.Load("go-client/.env") + if err != nil { + fmt.Println("Error loading .env file") + return + } + + client, err := createNacosClient() + if err != nil { + logger.Fatalf("Failed to create nacos client: %v", err) + } + + retryConfig := map[string]int{ + "times": 3, + } + retryConfigJSON, err := json.Marshal(retryConfig) + if err != nil { + logger.Fatalf("Unable to process config: %v", err) + } + + metadata := map[string]string{ + "cluster": "chat", + + "id": "1", + + "llm-meta.provider": "deepseek", + + "llm-meta.retry_policy.name": "CountBased", + + "llm-meta.retry_policy.config": string(retryConfigJSON), + + "name": "deepseek-v2-chat-instance", + + "llm-meta.api_keys": os.Getenv("API_KEY"), + + "llm-meta.fallback": "false", + } + + success, err := client.RegisterInstance(vo.RegisterInstanceParam{ + ServiceName: ServiceName, + GroupName: NacosGroup, + Weight: 10, + Enable: true, + Healthy: true, + Ephemeral: true, // temporary instance, will be removed on disconnect + Metadata: metadata, + }) + + if err != nil { + logger.Fatalf("Register service instant failed: %v", err) + } + if !success { + logger.Fatalf("Register service instant failed，please check Nacos logs") + } + + logger.Infof("Service registered instance success on [%s] target cluster: [chat]", ServiceName) + logger.Info("Programme running，press Ctrl+C to exit") + + quit := make(chan os.Signal, 1) + signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM) + <-quit + + logger.Info("Received shut up signal，deregistering instance...") Review Comment: The phrase 'shut up signal' should be 'shutdown signal' for clarity and correctness. ```suggestion logger.Info("Received shutdown signal，deregistering instance...") ``` ########## llm/nacos/registry/register_deepseek_service.go: ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "encoding/json" + "os" + "os/signal" + "syscall" + "time" +) + +import ( + "github.com/dubbogo/gost/log/logger" + + "github.com/nacos-group/nacos-sdk-go/clients" + "github.com/nacos-group/nacos-sdk-go/clients/naming_client" + "github.com/nacos-group/nacos-sdk-go/common/constant" + "github.com/nacos-group/nacos-sdk-go/vo" +) + +// Nacos server configuration +const ( + NacosServerIP = "127.0.0.1" + NacosServerPort = 8848 + NacosNamespace = "" + NacosGroup = "test_llm_registry_group" + + InstanceIP = "192.168.1.11" + InstancePort = 8002 + ServiceName = "deepseek-service" +) + +// Create and return a Nacos client +func createNacosClient() (naming_client.INamingClient, error) { + nacosHost := os.Getenv("NACOS_HOST") + if nacosHost == "" { + nacosHost = NacosServerIP + } + serverConfigs := []constant.ServerConfig{ + *constant.NewServerConfig(nacosHost, NacosServerPort), + } + clientConfig := *constant.NewClientConfig( + constant.WithNamespaceId(NacosNamespace), + constant.WithTimeoutMs(5000), + constant.WithNotLoadCacheAtStart(true), + constant.WithLogDir("/tmp/nacos/log"), + constant.WithCacheDir("/tmp/nacos/cache"), + constant.WithLogLevel("info"), + ) + return clients.NewNamingClient( + vo.NacosClientParam{ + ClientConfig: &clientConfig, + ServerConfigs: serverConfigs, + }, + ) +} + +func main() { + client, err := createNacosClient() + if err != nil { + logger.Fatalf("Failed to create nacos client: %v", err) + } + + retryConfig := map[string]int{ + "times": 3, + } + retryConfigJSON, err := json.Marshal(retryConfig) + + if err != nil { + logger.Fatalf("Unable to process config: %v", err) + } + + apiKeys := []map[string]string{} + apiKeys = append(apiKeys, map[string]string{ + "name": "api_key_1", + "key": os.Getenv("API_KEY"), + }) + apiKeysJSON, err := json.Marshal(apiKeys) + + if err != nil { + logger.Fatalf("Unable to process apikeys: %v", err) + } + + metadata := map[string]string{ + "cluster": "chat", + + "id": "1", + + "llm-meta.provider": "deepseek", + + "llm-meta.retry_policy.name": "CountBased", + + "llm-meta.retry_policy.config": string(retryConfigJSON), + + "name": "deepseek-v2-chat-instance", + + "llm-meta.api_keys": string(apiKeysJSON), + + "llm-meta.fallback": "false", + } + + success, err := client.RegisterInstance(vo.RegisterInstanceParam{ + Ip: InstanceIP, + Port: InstancePort, + ServiceName: ServiceName, + GroupName: NacosGroup, + Weight: 10, + Enable: true, + Healthy: true, + Ephemeral: true, // temporary instance, will be removed on disconnect + Metadata: metadata, + }) + + if err != nil { + logger.Fatalf("Register service instant failed: %v", err) + } + if !success { + logger.Fatalf("Register service instant failed，please check Nacos logs") + } + + logger.Infof("Service registered instance [%s:%d] success on [%s] target cluster: [chat]", InstanceIP, InstancePort, ServiceName) + logger.Info("Programme running，press Ctrl+C to exit") Review Comment: There's a spelling error: 'Programme' should be 'Program' in English. ```suggestion logger.Info("Program running，press Ctrl+C to exit") ``` ########## llm/nacos/registry/register_deepseek_service.go: ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "encoding/json" + "os" + "os/signal" + "syscall" + "time" +) + +import ( + "github.com/dubbogo/gost/log/logger" + + "github.com/nacos-group/nacos-sdk-go/clients" + "github.com/nacos-group/nacos-sdk-go/clients/naming_client" + "github.com/nacos-group/nacos-sdk-go/common/constant" + "github.com/nacos-group/nacos-sdk-go/vo" +) + +// Nacos server configuration +const ( + NacosServerIP = "127.0.0.1" + NacosServerPort = 8848 + NacosNamespace = "" + NacosGroup = "test_llm_registry_group" + + InstanceIP = "192.168.1.11" + InstancePort = 8002 + ServiceName = "deepseek-service" +) + +// Create and return a Nacos client +func createNacosClient() (naming_client.INamingClient, error) { + nacosHost := os.Getenv("NACOS_HOST") + if nacosHost == "" { + nacosHost = NacosServerIP + } + serverConfigs := []constant.ServerConfig{ + *constant.NewServerConfig(nacosHost, NacosServerPort), + } + clientConfig := *constant.NewClientConfig( + constant.WithNamespaceId(NacosNamespace), + constant.WithTimeoutMs(5000), + constant.WithNotLoadCacheAtStart(true), + constant.WithLogDir("/tmp/nacos/log"), + constant.WithCacheDir("/tmp/nacos/cache"), + constant.WithLogLevel("info"), + ) + return clients.NewNamingClient( + vo.NacosClientParam{ + ClientConfig: &clientConfig, + ServerConfigs: serverConfigs, + }, + ) +} + +func main() { + client, err := createNacosClient() + if err != nil { + logger.Fatalf("Failed to create nacos client: %v", err) + } + + retryConfig := map[string]int{ + "times": 3, + } + retryConfigJSON, err := json.Marshal(retryConfig) + + if err != nil { + logger.Fatalf("Unable to process config: %v", err) + } + + apiKeys := []map[string]string{} + apiKeys = append(apiKeys, map[string]string{ + "name": "api_key_1", + "key": os.Getenv("API_KEY"), + }) + apiKeysJSON, err := json.Marshal(apiKeys) + + if err != nil { + logger.Fatalf("Unable to process apikeys: %v", err) + } + + metadata := map[string]string{ + "cluster": "chat", + + "id": "1", + + "llm-meta.provider": "deepseek", + + "llm-meta.retry_policy.name": "CountBased", + + "llm-meta.retry_policy.config": string(retryConfigJSON), + + "name": "deepseek-v2-chat-instance", + + "llm-meta.api_keys": string(apiKeysJSON), + + "llm-meta.fallback": "false", + } + + success, err := client.RegisterInstance(vo.RegisterInstanceParam{ + Ip: InstanceIP, + Port: InstancePort, + ServiceName: ServiceName, + GroupName: NacosGroup, + Weight: 10, + Enable: true, + Healthy: true, + Ephemeral: true, // temporary instance, will be removed on disconnect + Metadata: metadata, + }) + + if err != nil { + logger.Fatalf("Register service instant failed: %v", err) + } + if !success { + logger.Fatalf("Register service instant failed，please check Nacos logs") + } + + logger.Infof("Service registered instance [%s:%d] success on [%s] target cluster: [chat]", InstanceIP, InstancePort, ServiceName) + logger.Info("Programme running，press Ctrl+C to exit") + + quit := make(chan os.Signal, 1) + signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM) + <-quit + + logger.Info("Received shut up signal，deregistering instance...") Review Comment: The phrase 'shut up signal' should be 'shutdown signal' for clarity and correctness. ```suggestion logger.Info("Received shutdown signal，deregistering instance...") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
