FoghostCn commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2268820238
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL,
invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction
base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation
base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly
remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType ==
constant.ServiceKey
}
}
Review Comment:
If these lines of code are useless, they can be deleted, and the purpose of
this PR is to replace the config package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
