Copilot commented on code in PR #15613:
URL: https://github.com/apache/dubbo/pull/15613#discussion_r2253017250
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/AbstractNettyConnectionClient.java:
##########
@@ -378,7 +378,20 @@ public void operationComplete(ChannelFuture future) {
// Notify the connection is unavailable.
disconnectedPromise.trySuccess(null);
- doReconnect();
+ connectivityExecutor.schedule(
+ () -> {
+ try {
+ doConnect();
Review Comment:
The change from `doReconnect()` to `doConnect()` may alter the reconnection
behavior. `doReconnect()` likely contains reconnection-specific logic that
differs from the initial connection logic in `doConnect()`. Consider verifying
that `doConnect()` handles reconnection scenarios appropriately or restore the
use of `doReconnect()`.
```suggestion
doReconnect();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
