zrlw commented on code in PR #15604:
URL: https://github.com/apache/dubbo/pull/15604#discussion_r2249051421
##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/support/FailsafeLogger.java:
##########
@@ -47,8 +46,7 @@ public void setLogger(Logger logger) {
}
private String appendContextMessage(String msg) {
- return " [DUBBO] " + msg + ", dubbo version: " + Version.getVersion()
+ ", current host: "
- + NetUtils.getLocalHost();
+ return " [DUBBO] " + msg + ", dubbo version: " + Version.getVersion();
Review Comment:
the host information should be logged for existed exception checking apps,
you'd better log it at other location instead of omitting it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
