WangzJi commented on code in PR #15542:
URL: https://github.com/apache/dubbo/pull/15542#discussion_r2204406212
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -243,8 +245,15 @@ jobs:
key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
restore-keys: |
zookeeper-${{ runner.os }}-
- - name: "Test with maven"
+ - name: "Test with maven on JDK 8"
+ timeout-minutes: 90
+ if: ${{ matrix.jdk == '8' }}
+ run: |
+ set -o pipefail
+ ./mvnw ${{ env.MAVEN_ARGS }} clean test verify
-Pjacoco,'!jdk15ge-add-open',skip-spotless -DtrimStackTrace=false
-Dmaven.test.skip=false -Dcheckstyle.skip=false -Dcheckstyle_unix.skip=false
-Drat.skip=false -DembeddedZookeeperPath=${{ github.workspace }}/.tmp/zookeeper
2>&1 | tee >(grep -n -B 1 -A 200 "FAILURE! -- in" > test_errors.log)
Review Comment:
This follows the existing pattern in `build-and-test-scheduled-3.3.yml`.
https://github.com/apache/dubbo/blob/7e06055f1369a8c6a04940c990a1dbcdc6bcdc07/.github/workflows/build-and-test-scheduled-3.3.yml#L209C1-L222C523
JDK 8 uses `jacoco,'!jdk15ge-add-open'` while JDK 11+ uses
`jacoco,jdk15ge-simple,'!jdk15ge-add-open'`.
The `jdk15ge-simple` profile adds necessary `--add-opens` parameters for
JDK 15+ module system compatibility. JDK 8 doesn't have modules, so it doesn't
need these parameters.
This is the standard approach already used by the project for JDK version
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
