Copilot commented on code in PR #866:
URL: https://github.com/apache/dubbo-go-samples/pull/866#discussion_r2203216308
##########
integrate_test/config_yaml/tests/integration/main_test.go:
##########
@@ -36,7 +36,7 @@ func TestMain(m *testing.M) {
panic(err)
}
- greeterProvider, err = greet.NewGreetService(cli)
+ greeterProvider, err = greet.NewGreetService(cli,
client.WithInterface("com.apache.dubbo.sample.Greeter"))
Review Comment:
[nitpick] Extract the interface name "com.apache.dubbo.sample.Greeter" into
a well-named constant to avoid hard-coded magic strings and reduce the risk of
typos.
```suggestion
greeterProvider, err = greet.NewGreetService(cli,
client.WithInterface(GreeterInterfaceName))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
