aditya0yadav commented on code in PR #51:
URL: https://github.com/apache/dubbo-python/pull/51#discussion_r2197322588
##########
src/dubbo/client.py:
##########
@@ -84,68 +86,274 @@ def _initialize(self):
def unary(
self,
- method_name: str,
+ interface: Optional[Callable] = None,
+ method_name: Optional[str] = None,
+ params_types: Optional[List[Type]] = None,
+ return_type: Optional[Type] = None,
+ codec: Optional[str] = None,
request_serializer: Optional[SerializingFunction] = None,
response_deserializer: Optional[DeserializingFunction] = None,
) -> RpcCallable:
- return self._callable(
- MethodDescriptor(
- method_name=method_name,
- arg_serialization=(request_serializer, None),
- return_serialization=(None, response_deserializer),
- rpc_type=RpcTypes.UNARY.value,
+ """
+ Create unary RPC call.
+
+ Supports both automatic mode (via interface) and manual mode (via
method_name + params_types + return_type + codec).
+ """
+
+ # Validate
Review Comment:
Indeed i already completed the code for this
i also feel that way too and i will commit in a while for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
