Copilot commented on code in PR #863: URL: https://github.com/apache/dubbo-go-samples/pull/863#discussion_r2174084816
########## online_boutique/Makefile: ########## @@ -0,0 +1,182 @@ +#!/usr/bin/env make Review Comment: [nitpick] Using a shebang for `make` is unconventional since Makefiles are not directly executed as scripts. You may remove the shebang or change it to a more appropriate shell if this file needs to be run directly. ```suggestion ``` ########## online_boutique/Makefile: ########## @@ -0,0 +1,182 @@ +#!/usr/bin/env make +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# 定义服务列表和对应的可执行文件名 +SERVICES := adservice cartservice checkoutservice currencyservice emailservice frontendservice paymentservice productcatalogservice recommendationservice shippingservice + +# 定义服务目录名到可执行文件名的映射 +# 定义颜色输出 +BLUE := \033[34m +GREEN := \033[32m +YELLOW := \033[33m +RED := \033[31m +NC := \033[0m # No Color + +# 默认目标 +.PHONY: help +help: + @echo "$(BLUE)Online Boutique Makefile$(NC)" + @echo "$(GREEN)Available targets:$(NC)" + @echo " $(YELLOW)build-all$(NC) - 构建所有服务" + @echo " $(YELLOW)start-all$(NC) - 启动所有服务（后台运行）" + @echo " $(YELLOW)stop-all$(NC) - 停止所有服务" + @echo " $(YELLOW)clean-all$(NC) - 清理所有构建文件" + @echo " $(YELLOW)tidy-all$(NC) - 执行所有服务的 go mod tidy" + @echo " $(YELLOW)logs$(NC) - 查看所有服务日志" + @echo " $(YELLOW)status$(NC) - 检查所有服务状态" + @echo "" + @echo "$(GREEN)单个服务操作:$(NC)" + @echo " $(YELLOW)build-<service>$(NC) - 构建指定服务" + @echo " $(YELLOW)start-<service>$(NC) - 启动指定服务" + @echo " $(YELLOW)stop-<service>$(NC) - 停止指定服务" + @echo "" + @echo "$(GREEN)可用服务:$(NC) $(SERVICES)" + +# 构建所有服务 +.PHONY: build-all +build-all: + @echo "$(BLUE)构建所有服务...$(NC)" + @for service in $(SERVICES); do \ + echo "$(GREEN)构建 $$service...$(NC)"; \ + cd src/$$service && $(MAKE) build && cd ../..; \ + done + @echo "$(GREEN)所有服务构建完成！$(NC)" + +# 启动所有服务 +.PHONY: start-all +start-all: build-all setup + @echo "$(BLUE)启动所有服务...$(NC)" + @for service in $(SERVICES); do \ + echo "$(GREEN)启动 $$service...$(NC)"; \ + cd src/$$service; \ + nohup ./$$service > ../../logs/$$service.log 2>&1 & echo $$! > ../../pids/$$service.pid && cd ../..; \ Review Comment: [nitpick] Similar to the build target, consider using a subshell for navigation and process startup, e.g., `(cd src/$$service && nohup ./$$service > ../../logs/$$service.log 2>&1 & echo $! > ../../pids/$$service.pid)`, to simplify directory management. ```suggestion ( cd src/$$service && nohup ./$$service > ../../logs/$$service.log 2>&1 & echo $$! > ../../pids/$$service.pid ); \ ``` ########## online_boutique/Makefile: ########## @@ -0,0 +1,182 @@ +#!/usr/bin/env make +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# 定义服务列表和对应的可执行文件名 +SERVICES := adservice cartservice checkoutservice currencyservice emailservice frontendservice paymentservice productcatalogservice recommendationservice shippingservice + +# 定义服务目录名到可执行文件名的映射 +# 定义颜色输出 +BLUE := \033[34m +GREEN := \033[32m +YELLOW := \033[33m +RED := \033[31m +NC := \033[0m # No Color + +# 默认目标 +.PHONY: help +help: + @echo "$(BLUE)Online Boutique Makefile$(NC)" + @echo "$(GREEN)Available targets:$(NC)" + @echo " $(YELLOW)build-all$(NC) - 构建所有服务" + @echo " $(YELLOW)start-all$(NC) - 启动所有服务（后台运行）" + @echo " $(YELLOW)stop-all$(NC) - 停止所有服务" + @echo " $(YELLOW)clean-all$(NC) - 清理所有构建文件" + @echo " $(YELLOW)tidy-all$(NC) - 执行所有服务的 go mod tidy" + @echo " $(YELLOW)logs$(NC) - 查看所有服务日志" + @echo " $(YELLOW)status$(NC) - 检查所有服务状态" + @echo "" + @echo "$(GREEN)单个服务操作:$(NC)" + @echo " $(YELLOW)build-<service>$(NC) - 构建指定服务" + @echo " $(YELLOW)start-<service>$(NC) - 启动指定服务" + @echo " $(YELLOW)stop-<service>$(NC) - 停止指定服务" + @echo "" + @echo "$(GREEN)可用服务:$(NC) $(SERVICES)" + +# 构建所有服务 +.PHONY: build-all +build-all: + @echo "$(BLUE)构建所有服务...$(NC)" + @for service in $(SERVICES); do \ + echo "$(GREEN)构建 $$service...$(NC)"; \ + cd src/$$service && $(MAKE) build && cd ../..; \ + done + @echo "$(GREEN)所有服务构建完成！$(NC)" + +# 启动所有服务 +.PHONY: start-all +start-all: build-all setup + @echo "$(BLUE)启动所有服务...$(NC)" + @for service in $(SERVICES); do \ + echo "$(GREEN)启动 $$service...$(NC)"; \ + cd src/$$service; \ + nohup ./$$service > ../../logs/$$service.log 2>&1 & echo $$! > ../../pids/$$service.pid && cd ../..; \ + sleep 2; \ + done + @echo "$(GREEN)所有服务已启动！$(NC)" + +# 停止所有服务 +.PHONY: stop-all +stop-all: + @echo "$(BLUE)停止所有服务...$(NC)" + @for service in $(SERVICES); do \ + if [ -f pids/$$service.pid ]; then \ + echo "$(YELLOW)停止 $$service...$(NC)"; \ + kill -TERM `cat pids/$$service.pid` 2>/dev/null || true; \ Review Comment: Using backticks for command substitution can be harder to read and nest. Consider using `$(...)` syntax for consistency and readability, e.g., `kill -TERM $(cat pids/$$service.pid)`. ```suggestion kill -TERM $(cat pids/$$service.pid) 2>/dev/null || true; \ ``` ########## online_boutique/Makefile: ########## @@ -0,0 +1,182 @@ +#!/usr/bin/env make +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# 定义服务列表和对应的可执行文件名 +SERVICES := adservice cartservice checkoutservice currencyservice emailservice frontendservice paymentservice productcatalogservice recommendationservice shippingservice + +# 定义服务目录名到可执行文件名的映射 +# 定义颜色输出 +BLUE := \033[34m +GREEN := \033[32m +YELLOW := \033[33m +RED := \033[31m +NC := \033[0m # No Color + +# 默认目标 +.PHONY: help +help: + @echo "$(BLUE)Online Boutique Makefile$(NC)" + @echo "$(GREEN)Available targets:$(NC)" + @echo " $(YELLOW)build-all$(NC) - 构建所有服务" + @echo " $(YELLOW)start-all$(NC) - 启动所有服务（后台运行）" + @echo " $(YELLOW)stop-all$(NC) - 停止所有服务" + @echo " $(YELLOW)clean-all$(NC) - 清理所有构建文件" + @echo " $(YELLOW)tidy-all$(NC) - 执行所有服务的 go mod tidy" + @echo " $(YELLOW)logs$(NC) - 查看所有服务日志" + @echo " $(YELLOW)status$(NC) - 检查所有服务状态" + @echo "" + @echo "$(GREEN)单个服务操作:$(NC)" + @echo " $(YELLOW)build-<service>$(NC) - 构建指定服务" + @echo " $(YELLOW)start-<service>$(NC) - 启动指定服务" + @echo " $(YELLOW)stop-<service>$(NC) - 停止指定服务" + @echo "" + @echo "$(GREEN)可用服务:$(NC) $(SERVICES)" + +# 构建所有服务 +.PHONY: build-all +build-all: + @echo "$(BLUE)构建所有服务...$(NC)" + @for service in $(SERVICES); do \ + echo "$(GREEN)构建 $$service...$(NC)"; \ + cd src/$$service && $(MAKE) build && cd ../..; \ Review Comment: [nitpick] Consider running build commands inside a subshell (e.g., `(cd src/$$service && $(MAKE) build)`) to avoid changing the current directory and manually returning back. ```suggestion (cd src/$$service && $(MAKE) build); \ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
