cnzakii commented on PR #50: URL: https://github.com/apache/dubbo-python/pull/50#issuecomment-2982768033
@aditya0yadav **Code Review Report and Suggestions** 1. All `.DS_Store` files should be excluded from the repository (e.g., via `.gitignore`). 2. The current `CodecRegistry` implementation should be replaced with Dubbo's `ExtensionLoader` mechanism to ensure that all extensions are centrally managed and follow a unified strategy. 3. Dependencies on libraries such as `orjson` and `pydantic` should be made optional. These modules should be structured as optional extensions, only imported when explicitly enabled by the user. 4. The current implementation of `JsonCodec` lacks generality. At a minimum, it should support Python’s basic data types as well as `dataclass` and `namedtuple`. 5. Although the `JsonCodec` class supports serializing multiple types, it only supports deserializing from `bytes` into a single type. This design is arguably suboptimal, as it forces users to implement a separate `CustomJsonCodec` for each type. This goes against the principle of ease-of-use and reusability. Due to the limited amount of code submitted, the review is brief but focused. I hope these suggestions are helpful to your development process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
