zrlw commented on PR #637:
URL: 
https://github.com/apache/dubbo-spi-extensions/pull/637#issuecomment-2979004910

   according to the comment - ```ttl default is twice the cycle-report time```, 
it seemed that the code ```jedisParams.px(ONE_DAY_IN_MILLISECONDS * 2);``` is 
also wrong.
   ```
   public RedisMetadataReport(URL url) {
           super(url);
           timeout = url.getParameter(TIMEOUT_KEY, DEFAULT_TIMEOUT);
           password = url.getPassword();
           this.root = url.getGroup(DEFAULT_ROOT);
           if (url.getParameter(CYCLE_REPORT_KEY, 
DEFAULT_METADATA_REPORT_CYCLE_REPORT)) {
               // ttl default is twice the cycle-report time
               jedisParams.px(ONE_DAY_IN_MILLISECONDS * 2);
           }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to