1kasa commented on code in PR #2909:
URL: https://github.com/apache/dubbo-go/pull/2909#discussion_r2121284729
##########
common/constant/default.go:
##########
@@ -29,24 +29,27 @@ const (
EmptyProtocol = "empty"
RouterProtocol = "router"
TriProtocol = "tri"
+ JsonRpcProtocol = "jsonrpc"
)
const (
- DefaultWeight = 100
- DefaultWarmup = 10 * 60 // in java here is 10*60*1000 because
of System.currentTimeMillis() is measured in milliseconds & in go time.Unix()
is second
- DefaultLoadBalance = "random"
- DefaultRetries = "2"
- DefaultRetriesInt = 2
- DefaultProtocol = "dubbo"
- DefaultRegTimeout = "5s"
- DefaultRegTTL = "15m"
- DefaultCluster = "failover"
- DefaultFailbackTimes = "3"
- DefaultFailbackTimesInt = 3
- DefaultFailbackTasks = 100
- DefaultRestClient = "resty"
- DefaultRestServer = "go-restful"
- DefaultPort = 20000
+ DefaultWeight = 100
+ DefaultWarmup = 10 * 60 // in java here is 10*60*1000
because of System.currentTimeMillis() is measured in milliseconds & in go
time.Unix() is second
+ DefaultLoadBalance = "random"
+ DefaultRetries = "2"
+ DefaultRetriesInt = 2
+ DefaultProtocol = "dubbo"
+ DefaultRegTimeout = "5s"
+ DefaultRegTTL = "15m"
+ DefaultCluster = "failover"
+ DefaultFailbackTimes = "3"
+ DefaultFailbackTimesInt = 3
+ DefaultFailbackTasks = 100
+ DefaultRestClient = "resty"
+ DefaultRestServer = "go-restful"
+ DefaultPort = 20000
+ DefaultRequestTimeoutStr = "3s"
+ DefaultRequestTimeoutDuration = 3 * time.Second
Review Comment:
done
##########
protocol/dubbo/dubbo_invoker.go:
##########
@@ -56,7 +57,18 @@ type DubboInvoker struct {
// NewDubboInvoker constructor
func NewDubboInvoker(url *common.URL, client *remoting.ExchangeClient)
*DubboInvoker {
+ // TODO: Temporary compatibility with old APIs, can be removed later
rt := config.GetConsumerConfig().RequestTimeout
+ if rt == "" {
+ if consumerConfRaw, ok :=
url.GetAttribute(constant.ConsumerConfigKey); ok {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
