marsevilspirit commented on code in PR #2906: URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2120285385
########## graceful_shutdown/shutdown.go: ########## @@ -49,8 +50,8 @@ const ( ) var ( - initOnce sync.Once - compatShutdown *config.ShutdownConfig + initOnce sync.Once + shutdown *global.ShutdownConfig Review Comment: This is actually a principled issue. We temporarily tolerate the config in the config package being a global variable because we will remove them later, but we cannot tolerate the config in the global package becoming a global variable, because we have decided to use options set through structure passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
