No-SilverBullet commented on code in PR #2888:
URL: https://github.com/apache/dubbo-go/pull/2888#discussion_r2102169158
##########
protocol/dubbo3/dubbo3_protocol.go:
##########
@@ -256,13 +258,25 @@ func (dp *DubboProtocol) openServer(url *common.URL,
tripleCodecType tripleConst
triOption := triConfig.NewTripleOption(opts...)
+ // TODO: remove config TLSConfig
+ // delete this branch
tlsConfig := config.GetRootConfig().TLSConfig
if tlsConfig != nil {
+ triOption.CACertFile = tlsConfig.CACertFile
triOption.TLSCertFile = tlsConfig.TLSCertFile
triOption.TLSKeyFile = tlsConfig.TLSKeyFile
- triOption.CACertFile = tlsConfig.CACertFile
triOption.TLSServerName = tlsConfig.TLSServerName
- logger.Infof("Triple Server initialized the TLSConfig
configuration")
+ logger.Infof("DUBBO3 Server initialized the TLSConfig
configuration")
+ } else if tlsConfRaw, tlsOk := url.GetAttribute(constant.TLSConfigKey);
tlsOk {
+ // use global TLSConfig handle tls
+ tlsConf := tlsConfRaw.(*global.TLSConfig)
Review Comment:
Add assert check, same with other similar code
tlsConf, ok := tlsConfRaw.(*global.TLSConfig)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
