1kasa commented on code in PR #2879:
URL: https://github.com/apache/dubbo-go/pull/2879#discussion_r2102116988
##########
registry/nacos/registry.go:
##########
@@ -284,16 +294,18 @@ func (nr *nacosRegistry) getAllSubscribeServiceNames(url
*common.URL) ([]string,
// handleServiceEvents receives service events from the listener and notifies
the notifyListener
func (nr *nacosRegistry) handleServiceEvents(listener registry.Listener,
notifyListener registry.NotifyListener) {
+ defer listener.Close()
Review Comment:
I changed the version before but did not submit it. It has now been
submitted.Destroye() actively called CloseListener(). Next() has a defer
fallback and sync. Once protection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
