MinatoWu commented on code in PR #2882:
URL: https://github.com/apache/dubbo-go/pull/2882#discussion_r2095678924
##########
registry/nacos/service_discovery.go:
##########
@@ -339,6 +346,46 @@ func (n *nacosServiceDiscovery)
toRegisterInstance(instance registry.ServiceInst
Ephemeral: true,
}
}
+func (n *nacosServiceDiscovery) toBatchRegisterInstances(instances
[]registry.ServiceInstance) vo.BatchRegisterInstanceParam {
+ var brins vo.BatchRegisterInstanceParam
+ var rins []vo.RegisterInstanceParam
+ for _, instance := range instances {
Review Comment:
But if I use RegisterInstance here, it won't be able to support multiple
instance registrations, and there will be an overwrite situation. Should we use
batchRegisterInstance uniformly instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
