zrlw commented on code in PR #15391:
URL: https://github.com/apache/dubbo/pull/15391#discussion_r2094750751


##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -36,6 +36,9 @@ jobs:
   check-format:
     name: "Check if code needs formatting"
     runs-on: ubuntu-latest
+    permissions:
+      # Give the default GITHUB_TOKEN write permission to commit the changed 
files back to the repository.
+      contents: write

Review Comment:
   the write permission is ganted for the PR branch of the forked repos such as 
 ```https://github.com/zrlw/dubbo```, it should not be trigged on 
```apache/dubbo``` because the code formatting issues should be fixed at forked 
repos, do you mean the forked repos is also under apache organization?
   by the way, this PR is posted only for for discussion of 
https://github.com/apache/dubbo/pull/15388. We still need to discuss whether 
it's necessary to do this.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to