nickva commented on code in PR #6080:
URL: https://github.com/apache/couchdb/pull/6080#discussion_r3732051063
##########
src/mango/src/mango_native_proc.erl:
##########
@@ -95,6 +100,21 @@ handle_call({prompt, [<<"nouveau_index_doc">>, Doc]},
_From, St) ->
Else
end,
{reply, Vals, St};
+handle_call({prompt, [<<"validate_fun">>, Selector0 | _Rest]}, _From, St) ->
+ try mango_selector:normalize(Selector0) of
+ Selector ->
+ case validate_vdu(Selector) of
+ ok -> {reply, true, St};
+ Error -> {reply, {error, Error}, St}
+ end
+ catch
+ throw:{mango_error, mango_selector, {invalid_operator, Op}} ->
+ Msg = io_lib:format("invalid operator: ~p", [Op]),
+ {reply, {error, {compilation_error, Msg}}, St};
+ throw:{mango_error, mango_util, {invalid_field_name, Field}} ->
Review Comment:
> This results in responses containing literal Erlang values, which I'd
rather avoid. I'm not sure how else to write a generic error formatting block
that does not have this problem.
We do have a function to format those in a dedicated module, that might work
```erlang
{_Code, _Name, Msg} = mango_error:info(Mod, Reason),
{reply, {error, {compilation_error, Msg}}, St}
```
Even if we didn't it might still be preferable to return some ugly error
which makes sense rather than a 500 crash which doesn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
