wohali commented on issue #1756: Adopt Credo inside Elixir test suite
URL: https://github.com/apache/couchdb/issues/1756#issuecomment-441325232
 
 
   My recommendation is:
   * decide on what we should filter out - beyond just line length, some of 
these are unhelpful (like complaining about long quote blocks and functions 
being too complex, esp. in a test suite)
   * fix all the errors
   * add steps to install the prerequisites for this to .travis.yml (elixir)
   * add a new `elixir-credo` target to `Makefile` that runs this and fails on 
any errors,
   * add the `elixir-credo` target to `make check`
   * file the PR
   * when Travis is green, we can merge

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to